disable buffering when POSTing for bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Add test for syncing with bulk upload when there are errors.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Change bulk upload batch size when there is a sync error.

- Cancel sync after try with smaller bulk upload batch size also throws error.
- Continue syncing when there is no error.
- Remove file from bulk upload black list only when upload succeeded.

Signed-off-by: Camila <hello@camila.codes>

Merge pull request #8137 from nextcloud/backport/8094/stable-3.16

[stable-3.16] Bugfix/use newer bulk upload checksum header

only send the md5 custom checksum header when server expects it

server before 32.0.0 release expects a custom header with an MD5
checksum during bulk upload

the header name is: X-File-MD5

see https://github.com/nextcloud/server/pull/51729

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

with release 32.0.0 md5 custom checksum is removed from bulkupload

makes our fake server require an md5 custom checksum for bulk upload
until version 32.0.0

starting with 32.0.0 this custom checksum must be empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix format of checksum header that was missing checksum type

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

sending header X-File-MD5 that is currently mandatory

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

automated tests of bulk upload needs to check checksums like real

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8131 from nextcloud/backport/8095/stable-3.16

[stable-3.16] fix: try to correct mtime on upsyncs

fix FileSystem::setModTime on x64 Windows with times > 2038

also removes some unused Utility methods

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix: try to correct mtime on upsyncs

Files with a modification time of less than 0 do usually not make sense
(and afaik the server doesn't accept them either).
--> attempt to update the modification time to _Time.now_ while
propagating

side note: I ran into this because KArchive/Ark(?) didn't consider the
extra time attributes on entries for a certain zip file, so it instead
used the standard time value of each zip entry which was set to <= 1980
for files and < 1970 for directories...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8130 from nextcloud/backport/8127/stable-3.16

[stable-3.16] stop using QFile api to delete a single local file

stop using QFile api to delete a single local file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8129 from nextcloud/backport/8128/stable-3.16

[stable-3.16] remove bogus check that tried to check for existing case clash conflict

remove bogus check that tried to check for existing case clash conflict

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8126 from nextcloud/backport/8121/stable-3.16

[stable-3.16] fix: move array to correct value in dict

fix: move array to correct value in dict

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8125 from nextcloud/backport/8122/stable-3.16

[stable-3.16] fix crash within FolderStatusModelTest

fix crash within FolderStatusModelTest

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8123 from nextcloud/backport/8118/stable-3.16

[stable-3.16] remove costly availability check that is never used

remove costly availability check that is never used

we never read the value computed

computing it means a recursive visit of the whole folder hierarchy which
could be taking a long time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8124 from nextcloud/backport/8120/stable-3.16

[stable-3.16] Bugfix/delete errors

better error message for user when deleting local items

we might be displaying too technical errors that the user will have no
way to understand

for example on macOS, we might be getting:
Unknown error: 513

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

when deleting a folder starts by making it read-write permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

we must not use QFile::remove that may fail on windows read-only files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

if we are going to need modified permissions: always change

we might need to change the permissions, so do it instead of trying to
be smart

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

do not change permissions of invalid items on discovery

if we are going to delete those items, we will make them have the proper
permissions when we need

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

always make the file we try to delete be read-write as required

on windows you must only delete read-write files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Qt 6.8 requires macSO 12 or higher: no need to compile against older

clean up preprocessor directives for older macOS releases that are not
supported by macOS minimum required release from the Qt 6.8 release we
require

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8117 from nextcloud/backport/8107/stable-3.16

[stable-3.16] fix(mac-crafter): Work around broken consecutive shell integration builds

fix(mac-crafter): Work around broken consecutive shell integration builds

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8116 from nextcloud/backport/8109/stable-3.16

[stable-3.16] fix(gui): remove ignored file notifications from Activity list

fix(gui): remove ignored file notifications from Activity list

These are informative notifications without any need/possibility to act
on immediately -- if a file is not synced it will be visible from the
shell integration anyway.

An eventual follow-up to this change would be to have a dialogue with an
overview of all files that were ignored (including the entry in the
ignore list that caused a specific file to be ignored).

Closes #6712

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8115 from nextcloud/backport/8114/stable-3.16

[stable-3.16] fix(mac): bump deployment target to 12.0

fix(mac): bump deployment target to 12.0

Qt 6.8 now requires macOS 12.0 as per https://doc.qt.io/qt-6.8/macos.html

for comparison, Qt 6.7 supported 11.0 and newer: https://doc.qt.io/qt-6.7/macos.html

also update the Packages project to refuse to install on anything older
than Monterey (12.0)

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8089 from nextcloud/backport/8080/stable-3.16

[stable-3.16] gui/macOS: Fix memory issues in Objective-C++ code for FileProvider support

gui/macOS: Properly retain/release NSFileProviderManager(s)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid need to retain/release things in file provider edit locally

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid crash from bad manager release

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid retain call on extensionNcAccount by allocing new string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Improve overall memory management in XPCUtils::getDomainManagers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Do not leak debug log string after use

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Use explicit type in connections array arg

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Correctly release objects received via FileProviderUtils functions

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Properly wait for eviction result in materialised items model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Do not leak local url and error objects in edit locally job

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Correctly retain/release manager and domain in sync status object

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Constify some Obj-C pointers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid unnecessary retain on alloced objects

Fixes leaks

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid leaking objc objects added to arrays and dicts

The array/dict will retain them

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8085 from nextcloud/backport/8081/stable-3.16

[stable-3.16] set `CFBundleDevelopmentRegion` to `"en"` and set `CFBundleAllowMixedLocalizations`

set CFBundleDevelopmentRegion to "en" and set CFBundleAllowMixedLocalizations

according to [1] the value should be a ISO 639-1 code, so let's correct
it

`CFBundleAllowMixedLocalizations` is the most interesting one: with this
being set the reported QLocale will no longer be English as well

(this also bumps the version info to 2025 :D)

[1]: https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledevelopmentregion

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8082 from nextcloud/backport/8077/stable-3.16

[stable-3.16] gui/tray: change the status icon background colour again

gui/tray: change the status icon background colour again

As discussed, it's supposed to be the same colour as the header
background indeed...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8079 from nextcloud/backport/8076/stable-3.16

[stable-3.16] gui/macOS: Fix broken file provider domain progress reporting in settings window

gui/macOS: Correctly release download/upload progress observers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Ensure file provider domain progress instances are correctly retained

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8074 from nextcloud/backport/8053/stable-3.16

[stable-3.16] gui/macOS: Do not assume accountState will always be valid in socket controller

gui/macOS: Do not assume accountState will always be valid

When removing an account this can change

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Constify methods in file provider socket controller

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8069 from nextcloud/backport/8067/stable-3.16

[stable-3.16] use our own craft cache on windows

use our own craft cache on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8068 from nextcloud/backport/8066/stable-3.16

[stable-3.16] fix Windows build

fix Windows build

`cl` didn't quite like it:

```
error C2445: result type of conditional expression is ambiguous: types 'QByteArray' and 'const char [1]' can be converted to multiple common types
```

just changing the `auto` to `QByteArray` results in the same compile error

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8057 from nextcloud/backport/8052/stable-3.16

[stable-3.16] use standard way to find the checkum type and really send it to server

use standard way to find the checkum type and really send it to server

will fix missing checksum for bulk upload

will ensure consistent behavior between bulk upload, plain old upload
and chunked upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8055 from nextcloud/backport/8041/stable-3.16

[stable-3.16] Bugfix/input pin title too wide

use a better and shorter title for input dialog for PIN code

we have to make sure the title is short and easy to understand

if it is too long, it will be truncated giving a bad experience for the
user

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8051 from nextcloud/backport/8050/stable-3.16

[stable-3.16] Bugfix/highlight too bright appimage

try to force the highlight to not be too bright

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8049 from nextcloud/backport/8045/stable-3.16

[stable-3.16] explicitly set colours for header items

align status icon display with e.g. Talk more

- status icons have now a white background/border
- "Invisible"/"Offline" icons are now hidden
- UserModel.status property is now available in QML too when needed

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

use colour from `Style` instead of palette for icons

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

explicitly set colours for header items

the _Universal_ theme notably sets [`icon.color` on `Button`s][0] and
also the [`color` on `Label`s][1], ignoring what's set through the
`palette` property ...

[0]: https://github.com/qt/qtdeclarative/blob/215619d71b69be02348e12dc2dfea087c3ec2abb/src/quickcontrols/universal/Button.qml#L23
[1]: https://github.com/qt/qtdeclarative/blob/215619d71b69be02348e12dc2dfea087c3ec2abb/src/quickcontrols/universal/Label.qml#L12

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

override French translations to fix a display issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

prepare for release 3.16.2

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8042 from nextcloud/backport/8041/stable-3.16

[stable-3.16] Bugfix/input pin title too wide

French title for input dialog for PIN is too wide

the whole title is not readable

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>